Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect shard number in series api #4577

Merged
merged 3 commits into from
Oct 29, 2021
Merged

Conversation

taisho6339
Copy link
Contributor

@taisho6339 taisho6339 commented Oct 28, 2021

What this PR does / why we need it:

  • Respect shard parameter in ingester series api
  • Add tests for it

Which issue(s) this PR fixes:
Fixes #4560

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@taisho6339 taisho6339 requested a review from a team as a code owner October 28, 2021 15:47
@CLAassistant
Copy link

CLAassistant commented Oct 29, 2021

CLA assistant check
All committers have signed the CLA.

* remove duplicate logic in instance
* format with goimport
Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, thanks!

@owen-d owen-d merged commit 0e21f02 into grafana:main Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Series API in ingester is not respecting shards parameters.
3 participants